Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add TaskOnKart dump type #368

Merged
merged 1 commit into from
Sep 4, 2024
Merged

add TaskOnKart dump type #368

merged 1 commit into from
Sep 4, 2024
+65 −18

Conversation

kitagry
Copy link
Member

@kitagry kitagry commented Apr 15, 2024 •
edited
Loading

Add type to TaskOnKart. we can set type.

class MyTask(gokart.TaskOnKart[str]):
    def run(self):
        self.dump(1)  # mypy error: expected str but got int
        self.dump('1')  # mypy ok

@kitagry kitagry marked this pull request as ready for review August 3, 2024 23:35
hirosassa
hirosassa approved these changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

test/test_build.py
@@ -79,6 +86,7 @@ def test_read_config(self):
config_file_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'config', 'test_config.ini')
gokart.utils.add_config(config_file_path)
output = gokart.build(_DummyTask(), reset_register=False)
assert_type(output, str)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍

hiro-o918
hiro-o918 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@hiro-o918 hiro-o918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitagry kitagry merged commit 85f3ebc into master Sep 4, 2024
5 checks passed
@kitagry kitagry deleted the add-build-type branch September 4, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirosassa hirosassa hirosassa approved these changes

@hiro-o918 hiro-o918 hiro-o918 approved these changes

@yokomotod yokomotod Awaiting requested review from yokomotod

@Hi-king Hi-king Awaiting requested review from Hi-king

@mski-iksm mski-iksm Awaiting requested review from mski-iksm

@ujiuji1259 ujiuji1259 Awaiting requested review from ujiuji1259

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitagry @hirosassa @hiro-o918