Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move matplotlib to Poetry dev dependency group #364

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

tkda-h3
Copy link
Contributor

@tkda-h3 tkda-h3 commented Apr 3, 2024

This PR relocates matplotlib from the main dependency group to the dev dependency group in our pyproject.toml since it's used exclusively for our test module here.

Including it as a main dependency is unnecessary for production builds.

@tkda-h3 tkda-h3 self-assigned this Apr 3, 2024
@tkda-h3 tkda-h3 changed the title Move matplotlib to dev group Move matplotlib to Poetry dev dependency group Apr 3, 2024
@tkda-h3 tkda-h3 requested a review from yokomotod April 3, 2024 08:28
Copy link
Collaborator

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kitagry kitagry merged commit afb661c into master Apr 5, 2024
5 checks passed
@kitagry kitagry deleted the move-matplotlib-to-dev branch April 5, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants