Feature/ Runtime validation of TaskInstanceParameter() and ListTaskInstanceParameter() by subclass bound #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujiuji1259
changed the title
ujiuji1259
changed the title
|
@mski-iksm Thank you for creating the PR! I forgot to make a PR after making this issue. |
|
@mski-iksm @hirosassa @Hi-king please review! |
Hi-king
reviewed
Feb 21, 2023
gokart/parameter.py
Outdated
| logger = getLogger(__name__) | ||
|
|
||
|
|
||
| class TaskInstanceParameter(luigi.Parameter): | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| bound = kwargs.pop('bound', gokart.TaskOnKart) |
There was a problem hiding this comment.
If you mean subtype bound, how about just use 'type' keyword? There might be both upper and lower for 'bound' keyword.
Hi-king
reviewed
Feb 21, 2023
Hi-king
reviewed
Feb 21, 2023
|
Thank you for the reviews! I found How about this implementation? Sample class TaskInstanceParameter(luigi.Parameter):
...
def _warn_on_wrong_param_type(self, param_name, param_value):
if self.__class__ != TaskInstanceParameter:
return
if not isinstance(param_value, self.expected_type):
raise TypeError(f'{param_value} is not an instance of {self.expected_type}') |
|
I've updated implementation to use _warn_on_wrong_param_type. Could you review again? @mski-iksm @hirosassa @Hi-king |
mski-iksm
requested changes
Mar 2, 2023
Hi-king
reviewed
Mar 2, 2023
|
@ganow Thx for suggesting nice feature for improving reliability :) @ujiuji1259 Thank you for the reasonable implementation! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #268
I've implemented runtime validation of TaskInstanceParameter() and ListTaskInstanceParameter() by subclass bound.
@ganow I'd like to use this feature, so I've created a PR based on your idea. Thank you for your feature request and the concrete implementation idea!