Hide private params from logs #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirosassa
approved these changes
Jul 31, 2022
mski-iksm
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented
__str__for task representations with only public parameters.Problems
When running the task with private parameters, the worker now emits the logs including the raw values of private parameters.
This is caused by the implementation of
__repr__that builds the task representation with all the significant parameters, andstr(task)calls it because__str__is not implemented. It is reasonable that__repr__Includes all the siginificant parameters since__repr__should identify the task, but I thinkstr(task)should not include private parameters.Solution
I've implemented
_get_task_string(only_public=False)and__str__, and added unittest for them.