Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: annotation of inherits_config_params #289

Merged
merged 1 commit into from
May 17, 2022
Merged

fix: annotation of inherits_config_params #289

merged 1 commit into from
May 17, 2022

Conversation

yuta100101
Copy link
Contributor

@yuta100101 yuta100101 commented May 16, 2022 •
edited
Loading

inherits_config_params is not called with TaskOnKart instance but TaskOnKart class itself or its subclass.
This suppresses mypy error.
And task_class is better for the parameter name than task.
I think this change does not have a significant impact on usage because inherits_config_params is used as decorator.

Hi-king
Hi-king approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@Hi-king Hi-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, task_class should be subtypes of Type[gokart.TaskOnKart]. 🆒

@Hi-king Hi-king merged commit 40299e8 into m3dev:master May 17, 2022
@yuta100101 yuta100101 deleted the fix/annotation branch May 17, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hi-king Hi-king Hi-king approved these changes

@mski-iksm mski-iksm Awaiting requested review from mski-iksm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuta100101 @Hi-king