Suppress heavy logs on test (fix #284) #285
Merged
+33
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-king
commented
May 8, 2022
| @@ -88,7 +92,7 @@ def test_build_dict_outputs(self): | |||
|
|
|||
| def test_failed_task(self): | |||
| with self.assertRaises(GokartBuildError): | |||
| gokart.build(_DummyFailedTask(), reset_register=False) | |||
| gokart.build(_DummyFailedTask(), reset_register=False, log_level=logging.CRITICAL) | |||
There was a problem hiding this comment.
Fail message is ERROR level, but not essential in this test
Hi-king
commented
May 8, 2022
| @@ -53,6 +53,8 @@ def run(self): | |||
| class RunTest(unittest.TestCase): | |||
|
|
|||
| def setUp(self): | |||
| luigi.setup_logging.DaemonLogging._configured = False | |||
| luigi.setup_logging.InterfaceLogging._configured = False | |||
There was a problem hiding this comment.
The same way as testing of luigi
https://github.com/spotify/luigi/blob/4d0576c7c265afcb228097af79f316ba0de0242c/test/cmdline_test.py#L110
Hi-king
commented
May 8, 2022
| @@ -31,7 +37,7 @@ def test_make_tree_info_complete(self): | |||
| task = _Task(param=1, sub=_SubTask(param=2)) | |||
|
|
|||
| # check after sub task runs | |||
| luigi.build([task], local_scheduler=True) | |||
| gokart.build(task, reset_register=False) | |||
There was a problem hiding this comment.
Not essential change, but more handy to use gokart.build
mski-iksm
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284
FIXES
luigi.setup_loggingconfigs on each setUp and tearDownluiginamespacePROBLEMS: heavy logs
https://github.com/m3dev/gokart/runs/6319432334?check_suite_focus=true
Reason1: cache of logging cofiguration
gokart/test/test_pandas_type_check_framework.py
Line 64 in 210e282
Reason2: gokart.build(log_level=...) only set log_level of
gokartnamespaceInfo level logs from
luiginamespace had been shown.