Skip to content

Mesoscale momentum parameterization with ANN#2

Merged
adcroft merged 7 commits into
m2lines:dev/m2linesfrom
Pperezhogin:m2lines-mesoscale-ann
Apr 28, 2025
Merged

Mesoscale momentum parameterization with ANN#2
adcroft merged 7 commits into
m2lines:dev/m2linesfrom
Pperezhogin:m2lines-mesoscale-ann

Conversation

@Pperezhogin
Copy link
Copy Markdown

This PR implements ANN parameterization of mesoscale eddies. Changes to the main branch include:

  • Module for ANN inference MOM_ANN.F90
  • Computing subgrid stress using ANN in MOM_Zanna_Bolton.F90

Default MOM_override for ANN usage:

#override USE_ZB2020 = True
#override USE_ANN = 3
#override ANN_STENCIL_SIZE = 3
#override ANN_TRUE_VORTICITY = True
#override ANN_FILE_TALL = /path/to/ocean3d/subfilter/FGR3/EXP1/model/Tall.nc

The netcdf files with ANN weights are attached ANN-weights.zip

Copy link
Copy Markdown

@adcroft adcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions in anticipation of what feedback this would get on dev/gfdl.

Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90 Outdated
@Pperezhogin
Copy link
Copy Markdown
Author

Hi @adcroft. Thanks for the comments.

All suggestions are incorporated. Regression did not change. New MOM_override reads:

#override USE_ZB2020 = True
#override ZB2020_USE_ANN = True
#override USE_CIRCULATION_IN_HORVISC = True
#override ZB2020_ANN_FILE_TALL = /path/to/ocean3d/subfilter/FGR3/EXP1/model/Tall.nc

Copy link
Copy Markdown

@adcroft adcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment thread src/parameterizations/lateral/MOM_Zanna_Bolton.F90
@adcroft adcroft mentioned this pull request Apr 28, 2025
@adcroft adcroft merged commit 407e802 into m2lines:dev/m2lines Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants