Mesoscale momentum parameterization with ANN#2
Merged
Conversation
adcroft
requested changes
Apr 28, 2025
adcroft
left a comment
There was a problem hiding this comment.
I've made some suggestions in anticipation of what feedback this would get on dev/gfdl.
Author
|
Hi @adcroft. Thanks for the comments. All suggestions are incorporated. Regression did not change. New MOM_override reads: |
adcroft
approved these changes
Apr 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements ANN parameterization of mesoscale eddies. Changes to the main branch include:
MOM_ANN.F90MOM_Zanna_Bolton.F90Default MOM_override for ANN usage:
The netcdf files with ANN weights are attached ANN-weights.zip