Allow wrap authority co-signing on swaps #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SC4RECOIN
commented
Jun 11, 2025
| // If provided, this signer is the one which will be checked against the wrap authorities. | ||
| pub wrap_authority: Option<Signer<'info>>, | ||
| // Will be set if a whitelisted authority is signing for a user | ||
| pub unwrap_authority: Option<Signer<'info>>, |
Collaborator
Author
There was a problem hiding this comment.
@Oighty I know you prefer the naming of wrap_authority but I think they are distinct authorities and some extensions might have separate whitelists for each
Collaborator
There was a problem hiding this comment.
Yeah, we can make two separate lists if we want. I was just focused on changing program_authority to something else because it doesn't have to be a program.
Collaborator
There was a problem hiding this comment.
Will require a bit of additional changes and some test refactoring based on the existing test suite + changes in #17
Oighty
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.