doc: Subkernel exception fix #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spaqin
reviewed
Jun 25, 2024
| @@ -178,6 +177,9 @@ In this case, without the preload, the delay after the core reset would need to | |||
| .. note:: | |||
| Subkernels can call subkernels on any other satellite, not only their own. Care should however be taken that different kernels do not call subkernels on the same satellite, or only very cautiously. If, e.g., a newer call overrides a subkernel that another caller is awaiting, unpredictable timeouts or locks may result, as the original subkernel will never return. There is not currently any mechanism to check whether a particular satellite is 'busy'; it is up to the programmer to handle this correctly. | |||
|
|
|||
| .. note:: | |||
| Exceptions raised by a subkernel can be caught by the originating subkernel, the master kernel (if awaited), or propagated to the host. This applies even when the subkernel was called by another subkernel, e.g. (``kernel -> subkernel_1 -> subkernel_2``). An exception in ``subkernel_2`` is sent straight to the master device and cannot be caught by ``subkernel_1``. | |||
There was a problem hiding this comment.
is sent triple space
This behavior may be changed in future (up for potential discussion) though... but OK for now
There was a problem hiding this comment.
Oh how odd. Fixed
architeuthidae
force-pushed
the
man-subkernel-fix
branch
from
9aa4ad8
to
c7f4449
Compare
Spaqin
reviewed
Jul 8, 2024
| Subkernels can call subkernels on any other satellite, not only their own. Care should however be taken that different kernels do not call subkernels on the same satellite, or only very cautiously. If, e.g., a newer call overrides a subkernel that another caller is awaiting, unpredictable timeouts or locks may result, as the original subkernel will never return. There is not currently any mechanism to check whether a particular satellite is 'busy'; it is up to the programmer to handle this correctly. | ||
|
|
||
| .. note:: | ||
| Exceptions raised by a subkernel can be caught by the originating subkernel, the master kernel (if awaited), or propagated to the host. This applies even when the subkernel was called by another subkernel, e.g. (``kernel -> subkernel_1 -> subkernel_2``). An exception in ``subkernel_2`` is sent straight to the master device and cannot be caught by ``subkernel_1``. |
There was a problem hiding this comment.
With recent changes to #2455 it's not true anymore, subkernels may catch exceptions raised by further subkernels now too.
architeuthidae
force-pushed
the
man-subkernel-fix
branch
from
c7f4449
to
b1d88e3
Compare
architeuthidae
force-pushed
the
man-subkernel-fix
branch
from
b1d88e3
to
eddfde5
Compare
|
Rebased for merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIQ Pull Request
Description of Changes
To match #2455 :)
Related Issue
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
Documentation Changes
cd doc/manual/; make html) to ensure no errors.Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.