Refactor test_scheduler to test relevant properties instead of exact order #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RID 2 has earlier due_date than RID 1 so it is chosen for running. RID 2 should complete all basic steps. Signed-off-by: yuk <[email protected]>
yuk-m-labs
force-pushed
the
1888-scheduler-test
branch
from
1f24196
to
6681586
Compare
Do not look into mod directly in individual tests Signed-off-by: yuk <[email protected]>
yuk-m-labs
changed the title
| def _notify(self, mod): | ||
| process_mod(self.experiments, mod) | ||
| for rid, events in self.status_events.items(): | ||
| if (mod["action"] == "setitem" and |
There was a problem hiding this comment.
Why would you both use process_mod and then look at the mod values?
This was referenced Jul 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIQ Pull Request
Description of Changes
Currently,
test_pending_priorityis checking the exact order of events.But it actually need test only:
Other test cases are also refactored to use similar methods.
Related Issue
Closes #1888
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
git commit --signoff, see copyright).Code Changes
flake8to check code style (follow PEP-8 style).flake8has issues with parsing Migen/gateware code, ignore as necessary.Git Logistics
git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.git show). Format:Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.