Pins busybox in data-processing to version 1.34.1 #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinaleonr
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained
nkinkade
commented
Feb 4, 2022
There was a problem hiding this comment.
I asked myself that same question when I was creating this PR. I was lazy, and let it go, but now you've called me out on it. There is no good reason, other than an inconsistency on my part. I just made another commit to this PR which changes it to 1.34. I had chosen 1.34 for k8s-support (instead of the more specific 1.34.1), with the thought that it was okay, and maybe even good, to fetch the latest patch-level release of the .1.34.x release. If it's good for k8s-support, then it is good here too.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the larger project to pin and/or update container image version in our clusters.l
This change is