Relax threshold for bq_gardener_historical_throughput alerts #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-soltesz
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @cristinaleonr)
config/federation/prometheus/alerts.yml, line 843 at r1 (raw file):
# datatypes under processing by the v2 pipeline falls below 1 date / day. # The bq_gardener_historical_throughput metric is under the bigquery exporter 3h # deployment, so the timeout for this alert is 3 hours and 10 minutes.
The comment is now out of date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bq_gardener_historical_throughputquery is run every 3h.The current threshold for the alerts that use this query is 3h and 10mins. T
he GardenerHistoricalThroughputIsStalled alert fired because it took BQ Exporter 3h and 13mins to report the new throughput.
This PR is adjusting the threshold to 4h.
Example:
Alert condition became true at 18:15 and resolved itself at 21:28 (3h and 13mins later).
https://prometheus.mlab-oti.measurementlab.net/graph?g0.expr=increase(gardener_jobs_total%7Bdaily%3D%22false%22%2Cstatus%3D%22success%22%7D%5B1d%5D)%20%3E%200%20unless%20on(datatype)%20bq_gardener_historical_throughput%20%3E%200&g0.tab=0&g0.stacked=0&g0.show_exemplars=0&g0.range_input=3h28m21s591ms&g0.end_input=2022-02-03%2021%3A40%3A04&g0.moment_input=2022-02-03%2021%3A40%3A04
This change is