Update or prepare bigquery exporter queries to use v2 ndt5 tables #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinaleonr
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
I assume [this alert] (https://github.com/m-lab/prometheus-support/blob/02e6fcfaa32db1c039fd68110f242551685c072e/config/federation/prometheus/alerts.yml#L7441) that uses bq_daily_tests won't misfire while the update is deployed because it has to do with switch discards and not the actual number of ndt5 rows.
Reviewable status:
complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates or prepares existing bigquery exporter queries for the pending changes to the ndt5 tables.
Since production will be updated last, the references to
measurement-lab.ndt.ndt5are replaced with references to (the equivalent)measurement-lab.ndt_raw.ndt5_legacy. This will allow the production deployment of the new table without breaking these queries before deployment. However, after production deployment, these references tondt5_legacywill be come stale, as the v1 parser and gardener will no longer be populating the base_tables.ndt5 v1 tables. For thebq_daily_tests.sqlquery, this will result in an underestimate of the ndt5 rows until the update is deployed.Part of:
This change is