Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update per-metro query to only use specified sites #863

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jan 7, 2022

Previously this dashboard reserved the upper-right panel to show all metros. But, I kept editing it to use only the selected metros. Since "all metros" is an option I think this panel should use the $site variable as all the other panels do. This change makes this modification.


This change is Reviewable

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, and for sure that panel shows the South America launch when eze01, lim01 and scl01 are selected!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Contributor Author

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah :) I kept modifying it to see the launch, so if it's that helpful, why not make it permanent.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit b3ecbca into master Jan 7, 2022
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-update-dashboard branch January 7, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants