Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wiki entry for Cloud_TooManyAppEngineVersions alert #859

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Dec 23, 2021

After the Cloud_TooManyAppEngineVersions fired in staging, I created m-lab/etl#1042 to help do this automatically. This is also a good time to update the description to reference the Alerts and troubleshooting wiki.

@SaiedKazemi what additional information would be helpful here or in the wiki?

@nkinkade also does this look right to you?


This change is Reviewable

Move alert description for Cloud_TooManyAppEngineVersions to the Alerts and troubleshooting wiki.
Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: The ops-tracker wiki entry references mlab-sandbox for the AppEngine console link. It should probably reference mlab-oti instead. Thanks for growing the "playbook" wiki!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @SaiedKazemi)

Copy link
Contributor Author

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Fixed the reference to mlab-oti.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @SaiedKazemi)

@SaiedKazemi
Copy link
Member


config/federation/prometheus/alerts.yml, line 969 at r1 (raw file):

    annotations:
      summary: Too many AppEngine versions for the project.
      description: https://github.com/m-lab/ops-tracker/wiki/Alerts-&-Troubleshooting#cloud_toomanyappengineversions

Looking at the contents of this link, I have two comments under Troubleshooting:

  1. It seems to me that the second bullet should be a part of the first bullet or a sub-bullet of it.
  2. I think the third bullet will be more clear if it read: ... includes a garbage collection script called delete-appengine.sh .... Run this script manually to remove old service versions.

Copy link
Contributor Author

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @SaiedKazemi)


config/federation/prometheus/alerts.yml, line 969 at r1 (raw file):

Previously, SaiedKazemi (Saied Kazemi) wrote…

Looking at the contents of this link, I have two comments under Troubleshooting:

  1. It seems to me that the second bullet should be a part of the first bullet or a sub-bullet of it.
  2. I think the third bullet will be more clear if it read: ... includes a garbage collection script called delete-appengine.sh .... Run this script manually to remove old service versions.

Thank you, I've updated the entry. PTAL?

@stephen-soltesz
Copy link
Contributor Author

I believe @SaiedKazemi will be OOO - so I'll merge this TBR if he has more feedback.

@stephen-soltesz stephen-soltesz merged commit 31e8d45 into master Jan 4, 2022
@stephen-soltesz stephen-soltesz deleted the stephen-soltesz-patch-1 branch January 4, 2022 17:10
@SaiedKazemi
Copy link
Member


config/federation/prometheus/alerts.yml, line 969 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Thank you, I've updated the entry. PTAL?

Looks good. Thanks for the changes.

Code quote:

https://github.com/m-lab/ops-tracker/wiki/Alerts-&-Troubleshooting#cloud_toomanyappengineversions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants