-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wiki entry for Cloud_TooManyAppEngineVersions alert #859
Conversation
Move alert description for Cloud_TooManyAppEngineVersions to the Alerts and troubleshooting wiki.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ops-tracker wiki entry references mlab-sandbox for the AppEngine console link. It should probably reference mlab-oti instead. Thanks for growing the "playbook" wiki!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @SaiedKazemi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Fixed the reference to mlab-oti.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @SaiedKazemi)
config/federation/prometheus/alerts.yml, line 969 at r1 (raw file):
Looking at the contents of this link, I have two comments under
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @SaiedKazemi)
config/federation/prometheus/alerts.yml, line 969 at r1 (raw file):
Previously, SaiedKazemi (Saied Kazemi) wrote…
Looking at the contents of this link, I have two comments under
Troubleshooting
:
- It seems to me that the second bullet should be a part of the first bullet or a sub-bullet of it.
- I think the third bullet will be more clear if it read:
... includes a garbage collection script called delete-appengine.sh .... Run this script manually to remove old service versions.
Thank you, I've updated the entry. PTAL?
I believe @SaiedKazemi will be OOO - so I'll merge this TBR if he has more feedback. |
config/federation/prometheus/alerts.yml, line 969 at r1 (raw file): Previously, stephen-soltesz (Stephen Soltesz) wrote…
Looks good. Thanks for the changes. Code quote: https://github.com/m-lab/ops-tracker/wiki/Alerts-&-Troubleshooting#cloud_toomanyappengineversions |
After the Cloud_TooManyAppEngineVersions fired in staging, I created m-lab/etl#1042 to help do this automatically. This is also a good time to update the description to reference the Alerts and troubleshooting wiki.
@SaiedKazemi what additional information would be helpful here or in the wiki?
@nkinkade also does this look right to you?
This change is