Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades Promeheus to v2.31.1 + removes old scraper resources #853

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

nkinkade
Copy link
Contributor

@nkinkade nkinkade commented Dec 14, 2021

This PR updates Prometheus to v2.31.1 in both the prometheus-federation and data-processing clusters. It also removes a number of old, defunct resources related to the retired scraper-cluster.


This change is Reviewable

The Scraper was retired quite a long time ago (replaced by Pusher). This
commit just removes a number of old files and resources that were still
hanging around.
Updates the Prometheus instances in both the prometheus-federation and
data-processing clusters. Also changes the value of the flag
--storage.tsdb.retention.time from 2880h to 120d for better readability.
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: -- thank you for the clean ups -- honestly did not realize there were still scraper cluster configs!

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@nkinkade nkinkade merged commit 2786779 into master Dec 14, 2021
@nkinkade nkinkade deleted the sandbox-kinkade branch December 14, 2021 21:14
@stephen-soltesz
Copy link
Contributor

@nkinkade would you please ensure that the removed dashboards are removed from Grafana as well? iirc, there's a way to do that via the grafana config?

@nkinkade
Copy link
Contributor Author

I have manually deleted all scraper dashboards from the Grafana instances in each project. I don't know that there is a Grafana config to remove dashboards (like there is for data sources). However, once the JSON provisioning file is gone for the dashboard, then you can manually delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants