Skip to content

Commit

Permalink
Update threshold for network annotations (#962)
Browse files Browse the repository at this point in the history
  • Loading branch information
stephen-soltesz authored Dec 5, 2022
1 parent 7dbd459 commit ce7c5f1
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions config/federation/prometheus/alerts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -906,11 +906,15 @@ groups:
triggering archive.

# NDT_AsnAnnotationRatioTooLowOrMissing fires when the client annotations on NDT
# tests appear to have too many failures or the bq_ndt_annotation_* metrics
# tests appear to have too many failures or the bq_annotation_* metrics
# disappear.
# NOTE: the threshold is significantly lower than the geo annotations because in
# practice we typically observe about 89-90% success rate, due to ~10% of
# lookups affirmatively not being found in the routeview dataset, i.e.
# `client.Network.Missing=True`.
- alert: DataPipeline_AsnAnnotationRatioTooLowOrMissing
expr: |
bq_annotation_asn_success / bq_annotation_total < 0.98
bq_annotation_asn_success / bq_annotation_total < 0.88
or absent(bq_annotation_asn_success / bq_annotation_total)
for: 3h
labels:
Expand Down

0 comments on commit ce7c5f1

Please sign in to comment.