Add job source bucket to output path #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7402
💛 - Coveralls |
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @stephen-soltesz)
storage/rowwriter.go line 181 at r1 (raw file):
// Get implements factory.SinkFactory func (sf *SinkFactory) Get(ctx context.Context, dp etl.DataPath) (row.Sink, etl.ProcessingError) { s, err := NewRowWriter(ctx, sf.client, sf.outputBucket, path.Join(dp.Bucket, dp.Path+".jsonl"))
Why are we changing this from json to jsonl?
stephen-soltesz
commented
Aug 2, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @cristinaleonr)
storage/rowwriter.go line 181 at r1 (raw file):
Previously, cristinaleonr (Cristina Leon) wrote…
Why are we changing this from
jsontojsonl?
Because these are JSONL files. The original extension was a misnomer.
cristinaleonr
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @cristinaleonr)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, when we change the archive source bucket for a datatype in the gardener config, the output data mixes results from two different sources. We can work around this by deleting the bucket directory, but this is slow. Better for them to remain separate.
This change includes the job source bucket in the output path so that the gardener system preserves the separation between the two directories.
Both the parser and gardener must agree on this path. So, this change must be deployed with its companion in etl-gardener m-lab/etl-gardener#407
Part of:
This change is