Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem with setting units to au or Bohr #530

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ahurta92
Copy link
Contributor

@ahurta92 ahurta92 commented Mar 6, 2024

If using au or bohr the set_derived_value would fail when type checking bare "atomic" in function call. std::string("atomic") ensures type checking will not fail.

@JonathonMisiewicz JonathonMisiewicz mentioned this pull request Mar 14, 2024
@ahurta92
Copy link
Contributor Author

@robertjharrison Quick change

@JonathonMisiewicz
Copy link
Contributor

@ahurta92 Rebase onto master so tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants