Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Methods for Zero value checks #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Methods for Zero value checks #10

wants to merge 2 commits into from

Conversation

LinaShadrach
Copy link
Contributor

  • this PR moves some checks that were in lio into qlbridge for value types:
    • add IsZero() bool method to Value interface
    • add ValueType.Zero() Value
  • creates new files for organization

@LinaShadrach LinaShadrach self-assigned this Aug 18, 2022
LinaShadrach
LinaShadrach commented Aug 18, 2022
View reviewed changes
value/value.go
@@ -156,6 +56,7 @@ type (
Value() interface{}
ToString() string
Type() ValueType
IsZero() bool
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the new method

LinaShadrach
LinaShadrach commented Aug 18, 2022
View reviewed changes
value/type.go
return false
}

func (m ValueType) Zero() Value {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the new method (all other changes are just moving code into separate files)

@LinaShadrach
Copy link
Contributor Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LinaShadrach LinaShadrach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LinaShadrach