Add assertTStringEqual() helper
#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
reviewed
Apr 19, 2025
Owner
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
This is a good improvement. Not sure if it'll work as is though.
Lib/test/test_string/_support.py
Outdated
| for actual, expected in zip(t.interpolations, interpolations, | ||
| strict=True): | ||
| if len(expected) == 2: | ||
| self.assertEqual(tuple(actual), expected + (None, '')) |
Owner
There was a problem hiding this comment.
I don't think the tuple(actual) call will work since Interpolation is not iterable.
Author
There was a problem hiding this comment.
Of course, sorry -- I wrote this on a computer without a working build of the branch. I've pushed a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @lysnikolaou
The tests are currently very verbose, as each attribute of each interpolation needs to be tested individually. This PR introduces a helper function to assert that a t-string is equal to a tuple of strings and a sequence of interpolation tuples.
A