Conversation
darabos
commented
Jul 20, 2025
Comment on lines
+31
to
+42
| - id: deptry | ||
| name: deptry for lynxkite-app | ||
| entry: bash -c 'cd lynxkite-app && deptry .' | ||
| - id: deptry | ||
| name: deptry for lynxkite-core | ||
| entry: bash -c 'cd lynxkite-core && deptry .' | ||
| - id: deptry | ||
| name: deptry for lynxkite-graph-analytics | ||
| entry: bash -c 'cd lynxkite-graph-analytics && deptry .' | ||
| - id: deptry | ||
| name: deptry for lynxkite-pillow-example | ||
| entry: bash -c 'cd lynxkite-pillow-example && deptry .' |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, running deptry . in the root doesn't work. osprey-oss/deptry#1060 (comment)
darabos
commented
Jul 20, 2025
Comment on lines
+16
to
+17
| DEP001 = ["matplotlib", "griffe", "pycrdt"] | ||
| DEP003 = ["matplotlib", "griffe", "pycrdt"] |
Contributor
Author
There was a problem hiding this comment.
These are conditional imports. Optional dependencies.
darabos
commented
Jul 20, 2025
|
|
||
| typeof = type # We have some arguments called "type". | ||
|
|
||
| CACHE_WRAPPER = None # Overwrite this to configure a caching mechanism. |
Contributor
Author
There was a problem hiding this comment.
To keep lynxkite-core lightweight, I've moved the joblib cache setup to lynxkite-app. I'm not sure it's worth it — let's reverse it if we see any downsides.
darabos
commented
Jul 20, 2025
Comment on lines
+247
to
+252
| view: str = "basic", | ||
| outputs: list[str] | None = None, | ||
| params: list[Parameter] | None = None, | ||
| slow: bool = False, | ||
| color: str | None = None, | ||
| cache: bool | None = None, |
Contributor
Author
There was a problem hiding this comment.
To address Griffe warnings, which I saw when I checked if mkdocs still works. (It does.)
darabos
force-pushed
the
darabos-uv-workspace
branch
from
f8d1960 to
20d727f
Compare
Contributor
Author
|
I'll merge this to fix CI. But I'd still be grateful for a review! 🙏 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to astral-sh/uv#14197 in uv 0.8.0 our GitHub Actions build is failing with:
I'm not sure what drove me to work on this on a Sunday at midnight, but I thought setting up a "workspace", as described in https://docs.astral.sh/uv/concepts/projects/workspaces/ would be the best solution. Seems actually pretty nice to me, but I had to work out a few issues. Like other than
lynxkite-app, our packages lacked a build system. And a lot of dependencies were wrongly declared. How did this ever work?