Skip to content

fix(web): list-item should supports linear layout #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sherry-hue merged 2 commits into from
May 20, 2025
Merged

fix(web): list-item should supports linear layout #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b7cc25
fix(web): list-item should supports linera layout
Sherry-hue May 20, 2025
1afa40a
Update .changeset/warm-goats-stare.md
Sherry-hue May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-goats-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lynx-js/web-elements": patch
---

fix: list-item should support linear layout.
6 changes: 4 additions & 2 deletions packages/web-platform/web-elements/src/common-css/linear.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ x-refresh-header,
x-refresh-view,
x-swiper-item,
x-viewpager-item-ng,
x-viewpager-ng {
x-viewpager-ng,
Comment thread
Sherry-hue marked this conversation as resolved.
list-item {
/*
--lynx-display-toggle is compile-time generated.
*/
Expand Down Expand Up @@ -195,7 +196,8 @@ x-refresh-header,
x-refresh-view,
x-swiper-item,
x-viewpager-item-ng,
x-viewpager-ng {
x-viewpager-ng,
list-item {
flex-wrap: var(--lynx-display-linear, nowrap)
var(
--lynx-display-flex,
Expand Down
5 changes: 5 additions & 0 deletions packages/web-platform/web-tests/tests/web-elements.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2346,6 +2346,11 @@ test.describe('web-elements test suite', () => {
expect(scrolltolower).toBeTruthy();
},
);
test('list-item-linear', async ({ page }, { titlePath }) => {
const title = getTitle(titlePath);
await gotoWebComponentPage(page, title);
await diffScreenShot(page, title, 'index');
});
});
test.describe('x-input', () => {
test('placeholder', async ({ page }, { titlePath }) => {
Expand Down
Binary file added ...web-elements.spec.ts-snapshots/x-list/list-item-linear/index-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added .../web-elements.spec.ts-snapshots/x-list/list-item-linear/index-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...s/web-elements.spec.ts-snapshots/x-list/list-item-linear/index-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
59 changes: 59 additions & 0 deletions packages/web-platform/web-tests/tests/web-elements/x-list/list-item-linear.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
<!DOCTYPE html>
<!-- Copyright 2024 The Lynx Authors. All rights reserved.
Licensed under the Apache License Version 2.0 that can be found in the
LICENSE file in the root directory of this source tree. -->
<html>
<head>
<meta charset="utf-8">
<title>web playground</title>
Comment thread
Sherry-hue marked this conversation as resolved.
<meta content="yes" name="apple-mobile-web-app-capable">
<meta content="default" name="apple-mobile-web-app-status-bar-style">
<meta content="telephone=no" name="format-detection">
<meta content="portrait" name="screen-orientation">
<meta
content="width=device-width,initial-scale=1.0,maximum-scale=1.0,user-scalable=no"
name="viewport"
>
<meta content="portrait" name="x5-orientation">
<link
href="/node_modules/@lynx-js/web-elements/index.css"
rel="stylesheet"
/>
<link
href="/web-elements.css"
rel="stylesheet"
/>

<style>
@import url("../../common.css");
x-list {
width: 100%;
height: 500px;
}

list-item {
border-width: 5px;
border-color: green;
height: 100px;
}

x-list x-view {
height: 80px;
background-color: red;
}
</style>
</head>

<body>
<script src="/web-elements.js" defer></script>
<x-view class="page">
<x-list need-visible-item-info>
<list-item><x-view></x-view></list-item>
<list-item><x-view></x-view></list-item>
<list-item><x-view></x-view></list-item>
<list-item><x-view></x-view></list-item>
<list-item><x-view></x-view></list-item>
</x-list>
</x-view>
</body>
</html>
Loading