Skip to content

Conversation

@colinaaa
Copy link
Collaborator

Summary

Fix Rspack EcoSystem CI failure (since CI could be something like true or github).

This would also make web-tests:build work on Windows.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@codecov
Copy link

codecov bot commented May 13, 2025

Bundle Report

Changes will increase total bundle size by 3.35kB (0.52%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@lynx-js/example-react-lynx-cjs 321.14kB 3.35kB (1.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @lynx-js/example-react-lynx-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
main.lynx.bundle 1.74kB 89.87kB 1.97%
.rspeedy/main/main-thread.js 744 bytes 40.8kB 1.86%
.rspeedy/main/background.*.js 864 bytes 39.91kB 2.21%

@codspeed-hq
Copy link

codspeed-hq bot commented May 13, 2025

CodSpeed Performance Report

Merging #784 will not alter performance

Comparing colinaaa:colin/0513/is-ci (75490a3) with main (a80c6f4)

Summary

✅ 2 untouched benchmarks

@colinaaa colinaaa marked this pull request as ready for review May 13, 2025 04:08
@colinaaa colinaaa requested a review from PupilTong as a code owner May 13, 2025 04:08
@colinaaa colinaaa enabled auto-merge May 13, 2025 04:11
@colinaaa colinaaa added this pull request to the merge queue May 13, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2025
## Summary

Fix [Rspack EcoSystem CI
failure](https://github.com/web-infra-dev/rspack/actions/runs/14986731044/job/42102260301)
(since `CI` could be something like `true` or `github`).

This would also make web-tests:build work on Windows.

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025
@colinaaa colinaaa added this pull request to the merge queue May 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025
@colinaaa colinaaa added this pull request to the merge queue May 13, 2025
Merged via the queue into lynx-family:main with commit ee03212 May 13, 2025
38 checks passed
@colinaaa colinaaa deleted the colin/0513/is-ci branch May 13, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants