Skip to content

Revert "feat(webpack): add StartupChunkDependenciesRuntimeModule to fix chunk splitting" #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinaaa merged 1 commit into from
May 6, 2025
Merged

Revert "feat(webpack): add StartupChunkDependenciesRuntimeModule to fix chunk splitting" #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/flat-hats-flow.md
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions packages/webpack/chunk-loading-webpack-plugin/src/ChunkLoadingWebpackPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@ import { RuntimeGlobals as LynxRuntimeGlobals } from '@lynx-js/webpack-runtime-g

import { createChunkLoadingRuntimeModule } from './ChunkLoadingRuntimeModule.js';
import { createCssChunkLoadingRuntimeModule } from './CssChunkLoadingRuntimeModule.js';
import { StartupChunkDependenciesPlugin } from './StartupChunkDependenciesPlugin.js';

import type { ChunkLoadingWebpackPluginOptions } from './index.js';

export class ChunkLoadingWebpackPluginImpl {
name = 'ChunkLoadingWebpackPlugin';
_asyncChunkLoading = true;

static chunkLoadingValue = 'lynx';

Expand All @@ -36,11 +34,6 @@ export class ChunkLoadingWebpackPluginImpl {
return;
}

new StartupChunkDependenciesPlugin({
chunkLoading: ChunkLoadingWebpackPluginImpl.chunkLoadingValue,
asyncChunkLoading: this._asyncChunkLoading,
}).apply(compiler);

// javascript chunk loading
compiler.hooks.thisCompilation.tap(this.name, (compilation) => {
const ChunkLoadingRuntimeModule = createChunkLoadingRuntimeModule(
Expand Down
76 changes: 0 additions & 76 deletions packages/webpack/chunk-loading-webpack-plugin/src/StartupChunkDependenciesPlugin.ts
View file
Open in desktop

This file was deleted.

78 changes: 0 additions & 78 deletions packages/webpack/chunk-loading-webpack-plugin/src/StartupChunkDependenciesRuntimeModule.ts
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions packages/webpack/chunk-loading-webpack-plugin/test/cases/chunk-loading/development/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,3 @@ it('should work with chunk loading require', async function() {
expect(lynx.requireModuleAsync).toBeCalled();
});
});

it('should contain startup chunk dependencies code', async () => {
const bundlePath = path.join(
__dirname,
'rspack.bundle.js',
);
const content = await fs.promises.readFile(bundlePath, 'utf-8');
// why appears twice:
// 1. Injected by StartupChunkDependenciesPlugin
// 2. Existing in test case's own bundle
expect((content.match(/Lynx startup chunk dependencies/g) || []).length).toBe(
2,
);
});
Loading