Skip to content

feat(react/runtime): impl list batch render #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaoachao merged 3 commits into from
Apr 29, 2025
Merged

feat(react/runtime): impl list batch render #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
418f947
feat: impl list batch render
DwwWxx Apr 24, 2025
7c30fe0
Merge branch 'main' into p/dingwang.wxx/impl_batch_render
DwwWxx Apr 28, 2025
bfa623a
Merge branch 'main' into p/dingwang.wxx/impl_batch_render
DwwWxx Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .changeset/calm-apples-buy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
"@lynx-js/react": patch
---

Supports list batch framework render with async resolve sub-tree properties and element tree.

```js
export default defineConfig({
plugins: [
pluginReactLynx({
enableParallelElement: true,
Comment thread
DwwWxx marked this conversation as resolved.
}),
// ...
],
});
```

```tsx
<list
/*
(1) experimental-batch-render-strategy={0}: Not enable batch render.
(2) experimental-batch-render-strategy={1}: Only Enable batch render.
(3) experimental-batch-render-strategy={2}: Enable batch render with async resolve property of list item subtree.
(4) experimental-batch-render-strategy={3}: Enable batch render with async resolve property and async resolve element tree of list item subtree.
*/
experimental-batch-render-strategy={3}
>
```
310 changes: 310 additions & 0 deletions packages/react/runtime/__test__/list.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2015,3 +2015,313 @@ describe('list-item JSXSpread', () => {
`);
});
});

describe('list componentAtIndexes', () => {
const s0 = __SNAPSHOT__(
<view>
<text>111</text>
<list id='list'>{HOLE}</list>
</view>,
);

const s1 = __SNAPSHOT__(
<list-item item-key={HOLE}>
<text>World</text>
</list-item>,
);

it('basic componentAtIndexes with async flush', () => {
const b = new SnapshotInstance(s0);
b.ensureElements();
const listRef = b.__elements[3];

const d0 = new SnapshotInstance(s1);
const d1 = new SnapshotInstance(s1);
const d2 = new SnapshotInstance(s1);
d0.setAttribute(0, { 'item-key': 'list-item-0' });
d1.setAttribute(0, { 'item-key': 'list-item-1' });
d2.setAttribute(0, { 'item-key': 'list-item-2' });
b.insertBefore(d0);
b.insertBefore(d1);
b.insertBefore(d2);
__pendingListUpdates.flush();

const fn = vi.fn();
const __original = globalThis.__FlushElementTree;
globalThis.__FlushElementTree = (_, options = {}) => {
fn(options);
};

{
const cellIndexes = [0, 1, 2];
const operationIDs = [0, 1, 2];
const enableReuseNotification = false;
const asyncFlush = true;
elementTree.triggerComponentAtIndexes(listRef, cellIndexes, operationIDs, enableReuseNotification, asyncFlush);
}

globalThis.__FlushElementTree = __original;
expect(fn.mock.calls).toMatchInlineSnapshot(`
[
[
{
"asyncFlush": true,
},
],
[
{
"asyncFlush": true,
},
],
[
{
"asyncFlush": true,
},
],
[
{
"elementIDs": [
203,
206,
209,
],
"listID": 202,
"operationIDs": [
0,
1,
2,
],
"triggerLayout": true,
},
],
]
`);
});

it('basic componentAtIndexes with no async flush', () => {
const b = new SnapshotInstance(s0);
b.ensureElements();
const listRef = b.__elements[3];

const d0 = new SnapshotInstance(s1);
const d1 = new SnapshotInstance(s1);
const d2 = new SnapshotInstance(s1);
d0.setAttribute(0, { 'item-key': 'list-item-0' });
d1.setAttribute(0, { 'item-key': 'list-item-1' });
d2.setAttribute(0, { 'item-key': 'list-item-2' });
b.insertBefore(d0);
b.insertBefore(d1);
b.insertBefore(d2);
__pendingListUpdates.flush();

const fn = vi.fn();
const __original = globalThis.__FlushElementTree;
globalThis.__FlushElementTree = (_, options = {}) => {
fn(options);
};
Comment thread
DwwWxx marked this conversation as resolved.

{
const cellIndexes = [0, 1, 2];
const enableReuseNotification = false;
const asyncFlush = false;
elementTree.triggerComponentAtIndexes(listRef, cellIndexes, [], enableReuseNotification, asyncFlush);
}

globalThis.__FlushElementTree = __original;
expect(fn.mock.calls).toMatchInlineSnapshot(`
[
[
{
"elementIDs": [
216,
219,
222,
],
"listID": 215,
"operationIDs": [],
"triggerLayout": true,
},
],
]
`);
});

it('basic componentAtIndexes with async flush and `enableReuseNotification` is true', () => {
const b = new SnapshotInstance(s0);
b.ensureElements();
const listRef = b.__elements[3];
const d0 = new SnapshotInstance(s1);
const d1 = new SnapshotInstance(s1);
const d2 = new SnapshotInstance(s1);
const d3 = new SnapshotInstance(s1);
const d4 = new SnapshotInstance(s1);
const d5 = new SnapshotInstance(s1);
d0.setAttribute(0, { 'item-key': 'list-item-0' });
d1.setAttribute(0, { 'item-key': 'list-item-1' });
d2.setAttribute(0, { 'item-key': 'list-item-2' });
d3.setAttribute(0, { 'item-key': 'list-item-3' });
d4.setAttribute(0, { 'item-key': 'list-item-4' });
d5.setAttribute(0, { 'item-key': 'list-item-5' });
b.insertBefore(d0);
b.insertBefore(d1);
b.insertBefore(d2);
b.insertBefore(d3);
b.insertBefore(d4);
b.insertBefore(d5);
__pendingListUpdates.flush();

{
const component = [];
component[0] = elementTree.triggerComponentAtIndex(listRef, 0);
component[1] = elementTree.triggerComponentAtIndex(listRef, 1);
component[2] = elementTree.triggerComponentAtIndex(listRef, 2);
elementTree.triggerEnqueueComponent(listRef, component[0]);
elementTree.triggerEnqueueComponent(listRef, component[1]);
elementTree.triggerEnqueueComponent(listRef, component[2]);
}

const fn = vi.fn();
const __original = globalThis.__FlushElementTree;
globalThis.__FlushElementTree = (_, options = {}) => {
const { listReuseNotification } = options;
if (listReuseNotification !== undefined) {
listReuseNotification['listElement'] = undefined;
}
fn(options);
};

{
const cellIndexes = [3, 4, 5];
const operationIDs = [3, 4, 5];
const enableReuseNotification = true;
const asyncFlush = true;
elementTree.triggerComponentAtIndexes(listRef, cellIndexes, operationIDs, enableReuseNotification, asyncFlush);
}

globalThis.__FlushElementTree = __original;
expect(fn.mock.calls).toMatchInlineSnapshot(`
[
[
{
"asyncFlush": true,
"listReuseNotification": {
"itemKey": "list-item-3",
"listElement": undefined,
},
},
],
[
{
"asyncFlush": true,
"listReuseNotification": {
"itemKey": "list-item-4",
"listElement": undefined,
},
},
],
[
{
"asyncFlush": true,
"listReuseNotification": {
"itemKey": "list-item-5",
"listElement": undefined,
},
},
],
[
{
"elementIDs": [
229,
232,
235,
],
"listID": 228,
"operationIDs": [
3,
4,
5,
],
"triggerLayout": true,
},
],
]
`);
});

it('should handle continuous componentAtIndexes on same index - self reuse', () => {
const b = new SnapshotInstance(s0);
b.ensureElements();
const listRef = b.__elements[3];
const d0 = new SnapshotInstance(s1);
const d1 = new SnapshotInstance(s1);
const d2 = new SnapshotInstance(s1);
d0.setAttribute(0, { 'item-key': 'list-item-0' });
d1.setAttribute(0, { 'item-key': 'list-item-1' });
d2.setAttribute(0, { 'item-key': 'list-item-2' });
b.insertBefore(d0);
b.insertBefore(d1);
b.insertBefore(d2);
__pendingListUpdates.flush();

{
const component = [];
component[0] = elementTree.triggerComponentAtIndex(listRef, 0);
component[1] = elementTree.triggerComponentAtIndex(listRef, 1);
component[2] = elementTree.triggerComponentAtIndex(listRef, 2);
elementTree.triggerEnqueueComponent(listRef, component[0]);
elementTree.triggerEnqueueComponent(listRef, component[1]);
elementTree.triggerEnqueueComponent(listRef, component[2]);
}

const fn = vi.fn();
const __original = globalThis.__FlushElementTree;
globalThis.__FlushElementTree = (_, options = {}) => {
fn(options);
};

{
const cellIndexes = [0, 1, 2];
const operationIDs = [0, 1, 2];
const enableReuseNotification = false;
const asyncFlush = true;
elementTree.triggerComponentAtIndexes(listRef, cellIndexes, operationIDs, enableReuseNotification, asyncFlush);
}

globalThis.__FlushElementTree = __original;
expect(fn.mock.calls).toMatchInlineSnapshot(`
[
[
{
"asyncFlush": true,
},
],
[
{
"asyncFlush": true,
},
],
[
{
"asyncFlush": true,
},
],
[
{
"elementIDs": [
242,
245,
248,
],
"listID": 241,
"operationIDs": [
0,
1,
2,
],
"triggerLayout": true,
},
],
]
`);
});
});
Loading
Loading