Skip to content

fix(web): When list-type is not specified, it is treated as single #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sherry-hue merged 1 commit into from
Apr 14, 2025
Merged

fix(web): When list-type is not specified, it is treated as single #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-masks-mate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lynx-js/web-elements": minor
---

fix: When list-type is not specified, it is treated as single formatting.
4 changes: 2 additions & 2 deletions packages/web-platform/web-elements/src/XList/x-list.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,15 @@ x-list[vertical-orientation="false"]::part(lower-threshold-observer) {
}

/* list-type single */
x-list[list-type="single"] {
x-list {
display: flex;
flex-direction: column;
align-items: stretch;
row-gap: var(--list-main-axis-gap);
column-gap: var(--list-cross-axis-gap);
}

x-list[list-type="single"][scroll-orientation="horizontal"] {
x-list[scroll-orientation="horizontal"] {
flex-direction: row;
row-gap: var(--list-cross-axis-gap);
column-gap: var(--list-main-axis-gap);
Expand Down
2 changes: 1 addition & 1 deletion packages/web-platform/web-tests/tests/web-elements/x-list/basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<body>
<script src="/web-elements.js" defer></script>
<x-view class="page">
<x-list list-type="single">
<x-list>
<list-item item-key="1" id="1"><x-view class="item"
>1</x-view></list-item>
<list-item item-key="2" id="2"><x-view class="item"
Expand Down
Loading