Skip to content

refactor(react): simplify template attribute descriptors #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yradex merged 1 commit into from
May 15, 2026
Merged

refactor(react): simplify template attribute descriptors #2643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/upgrade-tasm-039.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@lynx-js/react": patch
"@lynx-js/template-webpack-plugin": patch
"@lynx-js/lynx-bundle-rslib-config": patch
---

Update the @lynx-js/tasm dependency to 0.0.39 and align React template attribute descriptors with it.
2 changes: 1 addition & 1 deletion packages/react/runtime/__test__/element-template/fixtures/patch/props-update/case.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function run() {
kind: 'element',
type: 'view',
attributesArray: [
{ kind: 'attribute', binding: 'slot', key: 'id', attrSlotIndex: 0 },
{ kind: 'slot', key: 'id', attrSlotIndex: 0 },
],
children: [],
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/runtime/__test__/element-template/fixtures/patch/state-update/case.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export async function run() {
kind: 'element',
type: 'view',
attributesArray: [
{ kind: 'attribute', binding: 'slot', key: 'id', attrSlotIndex: 0 },
{ kind: 'slot', key: 'id', attrSlotIndex: 0 },
],
children: [],
},
Expand Down
9 changes: 3 additions & 6 deletions ...react/runtime/__test__/element-template/fixtures/render/child-siblings/templates.json.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@
"type": "text",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "text",
"binding": "static",
"value": "Slot Content 1"
}
],
Expand All @@ -23,9 +22,8 @@
"type": "text",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "text",
"binding": "static",
"value": "Slot Content 2"
}
],
Expand Down Expand Up @@ -72,9 +70,8 @@
"type": "raw-text",
"attributesArray": [
{
"kind": "attribute",
"kind": "slot",
"key": "text",
"binding": "slot",
"attrSlotIndex": 0
}
],
Expand Down
9 changes: 3 additions & 6 deletions ...ntime/__test__/element-template/fixtures/render/component-slot-content/templates.json.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@
"type": "text",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "text",
"binding": "static",
"value": "custom"
}
],
Expand All @@ -35,9 +34,8 @@
"type": "text",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "text",
"binding": "static",
"value": "child"
}
],
Expand Down Expand Up @@ -68,9 +66,8 @@
"type": "raw-text",
"attributesArray": [
{
"kind": "attribute",
"kind": "slot",
"key": "text",
"binding": "slot",
"attrSlotIndex": 0
}
],
Expand Down
9 changes: 3 additions & 6 deletions ...ages/react/runtime/__test__/element-template/fixtures/render/component/templates.json.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
"type": "text",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "text",
"binding": "static",
"value": "Hello"
}
],
Expand All @@ -34,9 +33,8 @@
"type": "text",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "text",
"binding": "static",
"value": "World"
}
],
Expand All @@ -58,9 +56,8 @@
"type": "raw-text",
"attributesArray": [
{
"kind": "attribute",
"kind": "slot",
"key": "text",
"binding": "slot",
"attrSlotIndex": 0
}
],
Expand Down
6 changes: 2 additions & 4 deletions ...runtime/__test__/element-template/fixtures/render/mapped-view-children/templates.json.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@
"type": "view",
"attributesArray": [
{
"kind": "attribute",
"kind": "slot",
"key": "id",
"binding": "slot",
"attrSlotIndex": 0
}
],
Expand Down Expand Up @@ -52,9 +51,8 @@
"type": "raw-text",
"attributesArray": [
{
"kind": "attribute",
"kind": "slot",
"key": "text",
"binding": "slot",
"attrSlotIndex": 0
}
],
Expand Down
3 changes: 1 addition & 2 deletions ...react/runtime/__test__/element-template/fixtures/render/mixed-children/templates.json.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@
"type": "raw-text",
"attributesArray": [
{
"kind": "attribute",
"kind": "slot",
"key": "text",
"binding": "slot",
"attrSlotIndex": 0
}
],
Expand Down
15 changes: 5 additions & 10 deletions .../react/runtime/__test__/element-template/fixtures/render/multiple-text/templates.json.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@
"type": "view",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "id",
"binding": "static",
"value": "1"
}
],
Expand All @@ -62,9 +61,8 @@
"type": "view",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "id",
"binding": "static",
"value": "2"
}
],
Expand All @@ -81,9 +79,8 @@
"type": "view",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "id",
"binding": "static",
"value": "3"
}
],
Expand All @@ -107,9 +104,8 @@
"type": "view",
"attributesArray": [
{
"kind": "attribute",
"kind": "static",
"key": "id",
"binding": "static",
"value": "4"
}
],
Expand Down Expand Up @@ -139,9 +135,8 @@
"type": "raw-text",
"attributesArray": [
{
"kind": "attribute",
"kind": "slot",
"key": "text",
"binding": "slot",
"attrSlotIndex": 0
}
],
Expand Down
3 changes: 1 addition & 2 deletions ...act/runtime/__test__/element-template/fixtures/render/nested-templates/templates.json.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@
"type": "raw-text",
"attributesArray": [
{
"kind": "attribute",
"kind": "slot",
"key": "text",
"binding": "slot",
"attrSlotIndex": 0
}
],
Expand Down
9 changes: 3 additions & 6 deletions ...untime/__test__/element-template/fixtures/render/opcodes-into-element-template/_shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,8 @@ const templates = [
type: 'raw-text',
attributesArray: [
{
kind: 'attribute',
kind: 'slot',
key: 'text',
binding: 'slot',
attrSlotIndex: 0,
},
],
Expand All @@ -47,9 +46,8 @@ const templates = [
type: 'view',
attributesArray: [
{
kind: 'attribute',
kind: 'slot',
key: 'id',
binding: 'slot',
attrSlotIndex: 0,
},
],
Expand Down Expand Up @@ -88,9 +86,8 @@ const templates = [
type: 'view',
attributesArray: [
{
kind: 'attribute',
kind: 'slot',
key: 'title',
binding: 'slot',
attrSlotIndex: 0,
},
],
Expand Down
Loading
Loading