Skip to content

fix(web-core): conditionally include Card and Component only when cardType !== 'react'. #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaoachao merged 2 commits into from
May 12, 2026
Merged

fix(web-core): conditionally include Card and Component only when cardType !== 'react'. #2610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca8e3e
fix(web-core): skip Card/Component sandbox params for react cardType
gaoachao May 12, 2026
1c2e35e
chore: update changeset
gaoachao May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curvy-shrimps-stay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lynx-js/web-core": patch
---

Conditionally pass Card and Component params based on cardType in background thread.
23 changes: 15 additions & 8 deletions packages/web-platform/web-core/ts/client/background/background-apis/createChunkLoading.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ import type {
BundleInitReturnObj,
} from '../../../types/index.js';

export function createChunkLoading(entryTemplateUrl: string): {
export function createChunkLoading(
entryTemplateUrl: string,
cardType: string,
): {
readScript: NativeApp['readScript'];
loadScript: NativeApp['loadScript'];
loadScriptAsync: NativeApp['loadScriptAsync'];
Expand Down Expand Up @@ -59,18 +62,18 @@ export function createChunkLoading(entryTemplateUrl: string): {
const createBundleInitReturnObj = (
jsContent: string,
): BundleInitReturnObj => {
const foo = new Function(
const paramNames: string[] = [
'postMessage',
'module',
'exports',
'lynxCoreInject',
'Card',
...(cardType !== 'react' ? ['Card'] : []),
'setTimeout',
'setInterval',
'clearInterval',
'clearTimeout',
'NativeModules',
'Component',
...(cardType !== 'react' ? ['Component'] : []),
Comment thread
gaoachao marked this conversation as resolved.
'ReactLynx',
'nativeAppId',
'Behavior',
Expand Down Expand Up @@ -98,24 +101,27 @@ export function createChunkLoading(entryTemplateUrl: string): {
// Lynx API
'requestAnimationFrame',
'cancelAnimationFrame',
];
const foo = new Function(
...paramNames,
jsContent,
) as BTSChunkEntry;
return {
init(lynxCoreInject) {
const module = { exports: {} };
const tt = lynxCoreInject.tt as any;
foo(
const args: unknown[] = [
undefined,
module,
module.exports,
lynxCoreInject,
tt.Card.bind(tt),
...(cardType !== 'react' ? [tt.Card.bind(tt)] : []),
tt.setTimeout,
tt.setInterval,
tt.clearInterval,
tt.clearTimeout,
tt.NativeModules,
tt.Component.bind(tt),
...(cardType !== 'react' ? [tt.Component.bind(tt)] : []),
tt.ReactLynx,
tt.nativeAppId,
tt.Behavior,
Expand All @@ -142,7 +148,8 @@ export function createChunkLoading(entryTemplateUrl: string): {
tt.global,
tt.requestAnimationFrame,
tt.cancelAnimationFrame,
);
];
(foo as Function).apply(undefined, args);
return module.exports;
},
};
Expand Down
3 changes: 2 additions & 1 deletion packages/web-platform/web-core/ts/client/background/background-apis/createNativeApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export async function createNativeApp(
timingSystem: TimingSystem,
nativeModulesMap: NativeModulesMap,
entryTemplateUrl: string,
cardType: string,
): Promise<NativeApp> {
const performanceApis = createPerformanceApis(
timingSystem,
Expand All @@ -69,7 +70,7 @@ export async function createNativeApp(
);
const reportError = mainThreadRpc.createCall(reportErrorEndpoint);
const { templateCache, loadScript, loadScriptAsync, readScript } =
createChunkLoading(entryTemplateUrl);
createChunkLoading(entryTemplateUrl, cardType);

mainThreadRpc.registerHandler(
updateBTSChunkEndpoint,
Expand Down
1 change: 1 addition & 0 deletions packages/web-platform/web-core/ts/client/background/background-apis/startBackgroundThread.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export function startBackgroundThread(
timingSystem,
nativeModulesMap,
entryTemplateUrl,
cardType,
);
const lynxCore = import(
/* webpackChunkName: "lynx-core-chunk" */
Expand Down
Loading