Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/decode-worker-heartbreak.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lynx-js/web-core": patch
---

Add bidirectional decode worker heartbreak liveness messages.
32 changes: 32 additions & 0 deletions packages/web-platform/web-core/tests/template-manager.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { describe, test, expect, vi, beforeEach } from 'vitest';
import { encode, type TasmJSONInfo } from '../ts/encode/index.js';
import { MagicHeader0, MagicHeader1 } from '../ts/constants.js';
import type { LynxViewInstance } from '../ts/client/mainthread/LynxViewInstance.js';
import type { HeartbreakMessage } from '../ts/client/decodeWorker/types.js';

// Import the worker script to execute it and register the handler
await import('../ts/client/decodeWorker/decode.worker.js');
Expand Down Expand Up @@ -49,12 +50,43 @@ const mockLynxViewInstance = {
}),
} as unknown as LynxViewInstance;

function isHeartbreakMessage(message: unknown): message is HeartbreakMessage {
return typeof message === 'object'
&& message !== null
&& (message as Partial<HeartbreakMessage>).type === 'heartbreak';
}

describe('Template Manager', () => {
beforeEach(() => {
vi.clearAllMocks();
globalThis.fetch = vi.fn();
});

test('should exchange worker-level heartbreak ack messages', async () => {
const postMessageSpy = vi.spyOn(globalThis, 'postMessage');

try {
const startedAt = performance.now();
let heartbreakMessages = postMessageSpy.mock.calls.filter(
([message]) => isHeartbreakMessage(message),
);

while (
heartbreakMessages.length < 2
&& performance.now() - startedAt < 5000
) {
await new Promise(resolve => setTimeout(resolve, 50));
heartbreakMessages = postMessageSpy.mock.calls.filter(
([message]) => isHeartbreakMessage(message),
);
}

expect(heartbreakMessages.length).toBeGreaterThanOrEqual(2);
} finally {
postMessageSpy.mockRestore();
}
});

test('should encode and decode correctly with version 1', async () => {
const templateUrl = 'http://example.com/template_version_test';
const encoded = encode(sampleTasm);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ import {
MagicHeader0,
MagicHeader1,
} from '../../constants.js';
import type { InitMessage, LoadTemplateMessage, MainMessage } from './types.js';
import type {
HeartbreakMessage,
InitMessage,
LoadTemplateMessage,
MainMessage,
} from './types.js';

import { wasmInstance } from '../wasm.js';
import type { PageConfig } from '../../types/PageConfig.js';
Expand All @@ -16,6 +21,9 @@ const wasmModuleLoadedPromise: Promise<void> = new Promise((resolve) => {
import { loadStyleFromJSON } from './cssLoader.js';
import { decodeBinaryMap } from '../../common/decodeUtils.js';

const HEARTBREAK_INTERVAL_MS = 1000;
let heartbreakTimer: ReturnType<typeof setTimeout> | undefined;

class StreamReader {
#reader: ReadableStreamDefaultReader<Uint8Array>;
#buffer: Uint8Array = new Uint8Array(0);
Expand Down Expand Up @@ -97,14 +105,40 @@ function decodeJSONMap<T>(buffer: Uint8Array): Record<string, T> {
return JSON.parse(jsonString);
}

function postHeartbreak() {
postMessage({ type: 'heartbreak' } as MainMessage);
}

function unrefTimer(timer: ReturnType<typeof setTimeout>) {
if (typeof timer === 'object' && timer !== null && 'unref' in timer) {
(timer as { unref: () => void }).unref();
}
}

function scheduleHeartbreak() {
if (heartbreakTimer !== undefined) {
return;
}
heartbreakTimer = setTimeout(() => {
heartbreakTimer = undefined;
postHeartbreak();
}, HEARTBREAK_INTERVAL_MS);
unrefTimer(heartbreakTimer);
}

self.onmessage = async (
event: MessageEvent<LoadTemplateMessage> | MessageEvent<InitMessage>,
event:
| MessageEvent<LoadTemplateMessage>
| MessageEvent<InitMessage>
| MessageEvent<HeartbreakMessage>,
) => {
const data = event.data;
if (data.type === 'init') {
const { wasmModule } = data;
wasmInstance.initSync({ module: wasmModule });
wasmModuleLoadedResolve();
} else if (data.type === 'heartbreak') {
scheduleHeartbreak();
} else if (data.type === 'load') {
const {
url,
Expand Down Expand Up @@ -462,3 +496,4 @@ async function handleJSON(
}

postMessage({ type: 'ready' } as MainMessage);
scheduleHeartbreak();
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,18 @@ export interface DoneMessage extends DecodeWorkerMessage {
type: 'done';
}

export interface HeartbreakMessage {
type: 'heartbreak';
}

export interface ReadyMessage {
type: 'ready';
}

export type WorkerMessage = LoadTemplateMessage;
export type WorkerMessage = LoadTemplateMessage | HeartbreakMessage;
export type MainMessage =
| SectionMessage
| ErrorMessage
| DoneMessage
| HeartbreakMessage
| ReadyMessage;
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ export class TemplateManager {
}
return;
}
if (msg.type === 'heartbreak') {
this.#worker?.postMessage({ type: 'heartbreak' });
return;
}
const { url } = msg;
const lynxViewInstancePromise = this.#lynxViewInstancesMap.get(url);
if (!lynxViewInstancePromise) return;
Expand Down
Loading