Skip to content

fix(react): silence invalid worklet warnings #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yradex merged 1 commit into from
May 9, 2026
Merged

fix(react): silence invalid worklet warnings #2586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/remove-invalid-mtf-warn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lynx-js/react": patch
---

Stop warning when `runWorklet` receives an invalid or missing main-thread function object. Invalid worklet contexts are still ignored, but nullish handler values no longer produce noisy `MainThreadFunction: Invalid function object` console output.
8 changes: 4 additions & 4 deletions packages/react/runtime/__test__/worklet-runtime/workletRuntime.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,14 +303,14 @@ describe('Worklet', () => {

it('should not throw when invalid worklet ctx', () => {
initWorklet();
consoleMock.mockClear();

globalThis.runWorklet({});
expect(consoleMock).lastCalledWith('MainThreadFunction: Invalid function object: {}');
globalThis.runWorklet(undefined);
expect(consoleMock).lastCalledWith('MainThreadFunction: Invalid function object: undefined');
globalThis.runWorklet(null);
expect(consoleMock).lastCalledWith('MainThreadFunction: Invalid function object: null');
globalThis.runWorklet(1);
expect(consoleMock).lastCalledWith('MainThreadFunction: Invalid function object: 1');

expect(consoleMock).not.toHaveBeenCalled();
});

it('should not throw when depth of argument exceeds limit', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/react/runtime/src/worklet-runtime/workletRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ function registerWorklet(_type: string, id: string, worklet: (...args: unknown[]
*/
function runWorklet(ctx: Worklet, params: ClosureValueType[], options?: RunWorkletOptions): unknown {
if (!validateWorklet(ctx)) {
console.warn('MainThreadFunction: Invalid function object: ' + JSON.stringify(ctx));
return;
}

Expand Down
Loading