-
Notifications
You must be signed in to change notification settings - Fork 122
feat(css): enable sourcemaps and remap diagnostics #2483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luhc228
merged 1 commit into
lynx-family:main
from
luhc228:hc/tasm-remap-css-col-and-row
Apr 22, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@lynx-js/css-serializer": patch | ||
| "@lynx-js/template-webpack-plugin": minor | ||
| --- | ||
|
|
||
| Add CSS source map support and source-mapped template encode diagnostics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@lynx-js/rspeedy": patch | ||
| --- | ||
|
|
||
| Enable CSS source maps by default in Rspeedy output config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@lynx-js/react-webpack-plugin": patch | ||
| --- | ||
|
|
||
| Support `@lynx-js/template-webpack-plugin` v0.11.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@lynx-js/css-extract-webpack-plugin": patch | ||
| --- | ||
|
|
||
| Support `@lynx-js/template-webpack-plugin` v0.11.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| applyTo: "packages/{tools/css-serializer,webpack/template-webpack-plugin,rspeedy/core}/**" | ||
| --- | ||
|
|
||
| When adding CSS diagnostics or source map plumbing across Rspeedy, css-serializer, and the template webpack plugin, preserve bundle-space `loc` data during debundle so warnings can be remapped through the main CSS source map back to original source files. Keep `cssSource` stable as `/cssId/<id>.css`, and only surface real source filenames in diagnostics when the mapped source path resolves to an existing file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
packages/rspeedy/core/test/config/output/source-map.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| // Copyright 2026 The Lynx Authors. All rights reserved. | ||
| // Licensed under the Apache License Version 2.0 that can be found in the | ||
| // LICENSE file in the root directory of this source tree. | ||
| import { describe, expect, test } from 'vitest' | ||
|
|
||
| import { createRspeedy } from '../../../src/index.js' | ||
|
|
||
| describe('output.sourceMap', () => { | ||
| test('defaults css source map to true', async () => { | ||
| const rspeedy = await createRspeedy({ | ||
| rspeedyConfig: {}, | ||
| }) | ||
|
|
||
| expect(rspeedy.getRspeedyConfig().output?.sourceMap).toEqual({ | ||
| css: true, | ||
| }) | ||
| }) | ||
|
|
||
| test('respects output.sourceMap false', async () => { | ||
| const rspeedy = await createRspeedy({ | ||
| rspeedyConfig: { | ||
| output: { | ||
| sourceMap: false, | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| expect(rspeedy.getRspeedyConfig().output?.sourceMap).toBe(false) | ||
| }) | ||
|
|
||
| test('respects output.sourceMap.css false', async () => { | ||
| const rspeedy = await createRspeedy({ | ||
| rspeedyConfig: { | ||
| output: { | ||
| sourceMap: { | ||
| css: false, | ||
| }, | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| expect(rspeedy.getRspeedyConfig().output?.sourceMap).toEqual({ | ||
| css: false, | ||
| }) | ||
| }) | ||
|
|
||
| test('merges css default with user js source map config', async () => { | ||
| const rspeedy = await createRspeedy({ | ||
| rspeedyConfig: { | ||
| output: { | ||
| sourceMap: { | ||
| js: 'source-map', | ||
| }, | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| expect(rspeedy.getRspeedyConfig().output?.sourceMap).toEqual({ | ||
| css: true, | ||
| js: 'source-map', | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.