Skip to content

refactor: create element without ref for suspense in main thread #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HuJean merged 2 commits into from
Apr 7, 2026
Merged

refactor: create element without ref for suspense in main thread #2426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e504f2
refactor: create element without ref for suspense in main thread
HuJean Apr 7, 2026
1faef9f
Merge branch 'main' into p/suspense-mainthread
HuJean Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/legal-zebras-sit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lynx-js/react": patch
---

Create element without ref for suspense in main thread.
38 changes: 23 additions & 15 deletions packages/react/runtime/src/lynx/suspense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,33 @@ export const Suspense: FunctionComponent<{ children: VNode | VNode[]; fallback:
(__MAIN_THREAD__ ? createElementMainThread : createElementBackground) as typeof createElementBackground;
const childrenRef = useRef<BackgroundSnapshotInstance>();

const newChildren = __createElement('wrapper', {
ref: (bsi: BackgroundSnapshotInstance) => {
if (bsi) {
childrenRef.current = bsi;
}
const newChildren = __createElement(
'wrapper',
__MAIN_THREAD__ ? {} : {
ref: (bsi: BackgroundSnapshotInstance) => {
if (bsi) {
childrenRef.current = bsi;
}
},
},
}, children);
children,
);

const newFallback = __createElement('wrapper', {
ref: (bsi: BackgroundSnapshotInstance) => {
if (bsi && childrenRef.current) {
const i = globalBackgroundSnapshotInstancesToRemove.indexOf(childrenRef.current.__id);
if (i !== -1) {
globalBackgroundSnapshotInstancesToRemove.splice(i, 1);
const newFallback = __createElement(
'wrapper',
__MAIN_THREAD__ ? {} : {
ref: (bsi: BackgroundSnapshotInstance) => {
if (bsi && childrenRef.current) {
const i = globalBackgroundSnapshotInstancesToRemove.indexOf(childrenRef.current.__id);
if (i !== -1) {
globalBackgroundSnapshotInstancesToRemove.splice(i, 1);
}
childrenRef.current = undefined;
}
childrenRef.current = undefined;
}
},
},
}, fallback);
fallback,
);

return __createElement(PreactSuspense, { fallback: newFallback }, newChildren);
};
Loading