Skip to content

feat: support suppress BROKEN warnings during compilation #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaoachao merged 1 commit into from
Jan 30, 2026
Merged

feat: support suppress BROKEN warnings during compilation #2157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/friendly-cats-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@lynx-js/react": patch
---

Use `disableDeprecatedWarning` option to suppress BROKEN warnings during compilation.

1. BROKEN: `getNodeRef`/`getNodeRefFromRoot`/`createSelectorQuery` on component instance is broken and MUST be migrated in ReactLynx 3.0, please use ref or lynx.createSelectorQuery instead.
2. BROKEN: `getElementById` on component instance is broken and MUST be migrated in ReactLynx 3.0, please use ref or lynx.getElementById instead.
Comment thread
gaoachao marked this conversation as resolved.
15 changes: 15 additions & 0 deletions packages/react/transform/__test__/fixture.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,21 @@ Component, View
]
`);
}

{
cfg.compat.disableDeprecatedWarning = true;
const result = await transformReactLynx(
`this.createSelectorQuery();
this.getElementById();`,
cfg,
);
expect(
await formatMessages(result.warnings, {
kind: 'warning',
color: false,
}),
).toMatchInlineSnapshot(`[]`);
}
});
});

Expand Down
122 changes: 42 additions & 80 deletions packages/react/transform/crates/swc_plugin_compat/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use serde::Deserialize;
use swc_core::common::comments::Comments;
use swc_core::common::util::take::Take;
use swc_core::{
common::{errors::HANDLER, DUMMY_SP},
common::{errors::HANDLER, Span, DUMMY_SP},
ecma::{
ast::*,
utils::{prepend_stmt, private_ident},
Expand Down Expand Up @@ -410,6 +410,12 @@ impl<C> CompatVisitor<C>
where
C: Comments + Clone,
{
fn emit_deprecation_warning(&self, span: Span, message: &str) {
if !self.opts.disable_deprecated_warning {
HANDLER.with(|handler| handler.struct_span_warn(span, message).emit());
}
}
Comment thread
gaoachao marked this conversation as resolved.

pub fn new(opts: CompatVisitorConfig, comments: Option<C>) -> Self {
CompatVisitor {
opts,
Expand Down Expand Up @@ -522,16 +528,10 @@ where
.iter()
.any(|pkg| pkg == import_src_str)
{
if !self.opts.disable_deprecated_warning {
HANDLER.with(|handler| {
handler
.struct_span_warn(
n.span,
format!("DEPRECATED: old package \"{import_src_str}\" is removed").as_str(),
)
.emit()
});
}
self.emit_deprecation_warning(
n.span,
&format!("DEPRECATED: old package \"{import_src_str}\" is removed"),
);

self.is_components_pkg = true;
}
Expand All @@ -543,19 +543,12 @@ where
.any(|pkg| pkg == import_src_str)
{
let new_runtime_pkg = &self.opts.new_runtime_pkg;
if !self.opts.disable_deprecated_warning {
HANDLER.with(|handler| {
handler
.struct_span_warn(
n.span,
format!(
"DEPRECATED: old runtime package \"{import_src_str}\" is changed to \"{new_runtime_pkg}\""
)
.as_str(),
)
.emit()
});
}
self.emit_deprecation_warning(
n.span,
&format!(
"DEPRECATED: old runtime package \"{import_src_str}\" is changed to \"{new_runtime_pkg}\""
),
);

*n.src = Str {
span: DUMMY_SP,
Expand Down Expand Up @@ -680,13 +673,10 @@ where
unreachable!("Unexpected JSXNamespacedName in component is polyfill - expected Ident")
}
}
if !self.opts.disable_deprecated_warning {
HANDLER.with(|handler| {
handler
.struct_span_warn(n.span, format!("DEPRECATED: syntax `<component is=? />` is deprecated, use `lazy` and `loadLazyBundle` exported from \"{}\" instead.", self.opts.new_runtime_pkg).as_str())
.emit()
});
}
self.emit_deprecation_warning(
n.span,
&format!("DEPRECATED: syntax `<component is=? />` is deprecated, use `lazy` and `loadLazyBundle` exported from \"{}\" instead.", self.opts.new_runtime_pkg),
);
}

// this test if the jsx element is lynx instrict element, like <view/>
Expand Down Expand Up @@ -965,18 +955,11 @@ where
None
}

let warning_transform_event_name = |old_name, new_name| {
if !self.opts.disable_deprecated_warning {
HANDLER.with(|handler| {
handler
.struct_span_warn(
n.span,
format!("DEPRECATED: old event props \"{old_name}\" is changed to \"{new_name}\"",)
.as_str(),
)
.emit()
});
}
let warning_transform_event_name = |old_name: &str, new_name: &str| {
self.emit_deprecation_warning(
n.span,
&format!("DEPRECATED: old event props \"{old_name}\" is changed to \"{new_name}\""),
);
};

if *self.is_target_jsx_element.last().unwrap_or(&false) {
Expand All @@ -1003,13 +986,7 @@ where
match &n.name {
JSXAttrName::Ident(id) => {
if id.sym == "lynx-key" {
if !self.opts.disable_deprecated_warning {
HANDLER.with(|handler| {
handler
.struct_span_warn(id.span, "DEPRECATED: lynx-key is changed to key")
.emit()
});
}
self.emit_deprecation_warning(id.span, "DEPRECATED: lynx-key is changed to key");

n.name = JSXAttrName::Ident(IdentName::new("key".into(), id.span));
}
Expand All @@ -1031,20 +1008,13 @@ where
.to_case(Case::Kebab);

if id.sym != new_id_str {
if !self.opts.disable_deprecated_warning {
HANDLER.with(|handler| {
handler
.struct_span_warn(
id.span,
format!(
"DEPRECATED: old JSXElementName \"{}\" is changed to \"{}\"",
id.sym, new_id_str
)
.as_str(),
)
.emit()
});
}
self.emit_deprecation_warning(
id.span,
&format!(
"DEPRECATED: old JSXElementName \"{}\" is changed to \"{}\"",
id.sym, new_id_str
),
);

*name = JSXElementName::Ident(IdentName::new(new_id_str.into(), id.span).into());
}
Expand All @@ -1062,24 +1032,16 @@ where
if let MemberProp::Ident(id) = &m.prop {
match id.sym.to_string().as_str() {
"getNodeRef" | "getNodeRefFromRoot" | "createSelectorQuery" => {
HANDLER.with(|handler| {
handler
.struct_span_warn(
n.span,
format!("BROKEN: {} on component instance is broken and MUST be migrated in ReactLynx 3.0, please use ref or lynx.createSelectorQuery instead.", id.sym).as_str(),
)
.emit()
});
self.emit_deprecation_warning(
n.span,
&format!("BROKEN: {} on component instance is broken and MUST be migrated in ReactLynx 3.0, please use ref or lynx.createSelectorQuery instead.", id.sym),
);
}
"getElementById" => {
HANDLER.with(|handler| {
handler
.struct_span_warn(
n.span,
format!("BROKEN: {} on component instance is broken and MUST be migrated in ReactLynx 3.0, please use ref or lynx.getElementById instead.", id.sym).as_str(),
)
.emit()
});
self.emit_deprecation_warning(
n.span,
&format!("BROKEN: {} on component instance is broken and MUST be migrated in ReactLynx 3.0, please use ref or lynx.getElementById instead.", id.sym),
);
}
&_ => {}
}
Expand Down
Loading