Skip to content

fix: replaceAll is not a function #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
upupming merged 2 commits into from
Jan 28, 2026
Merged

fix: replaceAll is not a function #2142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f75b9b
fix: replaceAll is not a function
upupming Jan 27, 2026
84c6e3f
feat: update changeset
upupming Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cool-peas-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lynx-js/react": patch
---

Fix "TypeError: not a function" error caused by `replaceAll` not supported in ES5.
2 changes: 1 addition & 1 deletion packages/react/runtime/src/lifecycle/patch/snapshotPatchApply.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export function snapshotPatchApply(snapshotPatch: SnapshotPatch): void {
// HMR-related
// Update the evaluated snapshot entryName from JS.
snapshotCreatorMap[uniqID] = evaluate<(uniqId: string) => string>(
snapshotCreatorMap[uniqID]!.toString().replaceAll('globDynamicComponentEntry', JSON.stringify(entryName)),
snapshotCreatorMap[uniqID]!.toString().replace(/globDynamicComponentEntry/g, JSON.stringify(entryName)),
);
}
break;
Expand Down
Loading