-
Notifications
You must be signed in to change notification settings - Fork 37
feat: add preact devtools panel #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d64c5bd to
44e63c6
Compare
3804948 to
41b9d76
Compare
talisk
requested changes
Jul 29, 2025
Collaborator
talisk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL, we should add Lynx License comments to the files
packages/devtools-frontend-lynx/front_end/panels/preact_devtools/BUILD.gn
Outdated
Show resolved
Hide resolved
packages/devtools-frontend-lynx/front_end/panels/preact_devtools/PreactDevtoolsPanel.ts
Show resolved
Hide resolved
packages/devtools-frontend-lynx/front_end/panels/preact_devtools/preact_devtools-meta.ts
Show resolved
Hide resolved
packages/devtools-frontend-lynx/front_end/panels/preact_devtools/preact_devtools.ts
Show resolved
Hide resolved
fd95623 to
83ec0cf
Compare
talisk
approved these changes
Jul 30, 2025
Collaborator
talisk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
colinaaa
pushed a commit
to lynx-family/lynx-stack
that referenced
this pull request
Aug 6, 2025
…tools (#1173) <!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> We are adding Preact Devtools Support for ReactLynx, this PR contains related changes for PreactDevtools to work properly. After this we can inspect ReactLynx App in LynxDevtool just like any Preact Web App: <img width="1620" alt="image" src="https://github.com/user-attachments/assets/3ffaa7af-0fc7-4637-970d-943d18fff616" /> Related PR: lynx-family/lynx-devtool#56 ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [x] Documentation updated (or not required). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a new event in development mode to provide up-to-date background snapshot instance information for improved DevTools support. * **Tests** * Simplified and updated global object mocking in test cases for better reliability. * Enhanced test environment setup by introducing an event emitter for more accurate event handling during tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "Preact Devtools" Panel to LynxDevtool, an example ReactLynx App demo: https://github.com/upupming/rspeedy-mininal-template/tree/feat/preact-devtools