Disabled serialization for JSON type columns #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colavitam
changed the title
|
This is great @colavitam. Thanks for this PR! |
booleanbetrayal
added a commit
that referenced
this pull request
Jul 16, 2015
Disabled serialization for JSON type columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default migration uses the JSON type for databases (such as Postgres) that support it. The concern no longer attempts to invalidly serialize the tokens field if it is backed by a JSON column. This fixes the TypeError encountered when the JSON field is nil (as it is by default). The tests have also been updated to test the JSON column type if it is available. I have also bumped the postgresql version on Travis CI to 9.3 so JSON datatypes would be available to test.
This also resolves #271 by explicitly checking if the tokens field is nil before attempting to delete expired tokens.