Username register login #128
Conversation
* Clean useless function in User concer * Delete references to 'login'
|
|
||
| if ActiveRecord::Base.connection.adapter_name.downcase.starts_with? 'mysql' | ||
| q = "BINARY uid = ? AND provider='email'" | ||
| elsif resource_params.include?(:username) |
There was a problem hiding this comment.
Instead of hard-coding to username, let's instead check against the authentication_keys config param. Devise docs are here:
https://github.com/plataformatec/devise/wiki/How-To:-Allow-users-to-sign-in-using-their-username-or-email-address#tell-devise-to-use-username-in-the-authentication_keys
|
I just made a commit based on your comment. What do you think ? Has mentionned in the doc, we should always make a request in the database with a lowered string (for email or others), instead of making the attempt to login failed even if case_insensitive_keys is not configured. |
| email = resource_params[:email] | ||
| end | ||
| # Check | ||
| field = (resource_params.keys.map(&:to_sym) & resource_class.authentication_keys).first |
|
@nicolas-besnard - as a side-note, I just want to say thanks for your contributions here (fixing bugs, proposing features, fielding issues, etc). Your time and effort are much appreciated 😃 |
|
My pleasure :) I like this gem, I use it on 2 professional project and 1 side projet. So I better be working on it ! |
WIP for #127
For the test, I just C/C the test for 'normal' user. I think it can be cleaned a little more. I know how to do it in Rspec. I'll dig into this later.