DeviseTokenAuth::Url.generate should accept relative path #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengqing
changed the title
mengqing
force-pushed
the
url-generate-relative-url
branch
from
cac9e03
to
f7d8f3d
Compare
|
Hi @MaicolBen, I'm not exactly sure why the spec failed. I've tried testing them locally and they all passed. Do you have any idea on why the spec is failing? |
MaicolBen
reviewed
Aug 18, 2019
| @@ -4,15 +4,10 @@ module DeviseTokenAuth::Url | |||
|
|
|||
| def self.generate(url, params = {}) | |||
| uri = URI(url) | |||
| query_params = Hash[URI.decode_www_form(uri.query || '')].merge(params) | |||
There was a problem hiding this comment.
The problem is that expiry gets lost here in rails 4.2 (/controllers/devise_token_auth/passwords_controller_test.rb:207). I thought URI is from ruby, so it's weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a relative url or empty string is passed to
DeviseTokenAuth::Url.generate, it should parse and return the same relative url back.