Facebook omniauth redirection is missing url when testing on localhost

[c0mrade]

Relating my previous issues :
#166

The second part has been resolved regarding api_user and user. However first part still remains that I get redirected to a page without a hostname, just has a path.

Solution to this problem could be in the OmniauthCallbacksController, method redirect_callbacks, this line :

redirect_route = "/#{Devise.mappings[devise_mapping].as_json["path"]}/#{params[:provider]}/callback"

change it to :

redirect_route = "#{request.protocol}#{request.host_with_port}/#{Devise.mappings[devise_mapping].as_json["path"]}/#{params[:provider]}/callback"

Tried it locally works, any objections, different ideas how to do this?

[c0mrade]

@lynndylanhurley can you see any issues with adding request protocol and port to the redirect_route?

[booleanbetrayal]

@c0mrade - I don't see any issues, and it should probably account for the full URL info anyhow. Do you mind putting together a quick PR and making sure all existing tests pass?

[c0mrade]

@booleanbetrayal sure, thanks for the response

[booleanbetrayal]

Should be closed as of #322