Skip to content

Commit

Permalink
Take into account passing "undefined" in updatesimulcastlayersbitrate (
Browse files Browse the repository at this point in the history
lodoyun authored Jun 21, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent f3ccb54 commit 550bcc3
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions erizo_controller/erizoClient/src/Stream.js
Original file line number Diff line number Diff line change
@@ -619,9 +619,10 @@ const Stream = (altConnectionHelpers, specInput) => {
// limit with maxVideoBW
const limitedBitrates = bitrates;
Object.keys(limitedBitrates).forEach((key) => {
if (limitedBitrates[key] > that.maxVideoBW) {
log.warning(`Trying to set bitrate ${limitedBitrates[key]} higher that max ${that.maxVideoBW}`
+ `in Layer ${key}`);
// explicitly passing undefined means assigning the max for that layer
if (limitedBitrates[key] > that.maxVideoBW || limitedBitrates[key] === undefined) {
log.info('message: updateSimulcastLayersBitrate defaulting to max bitrate,' +
`, layer :${key}, requested: ${limitedBitrates[key]}, max: ${that.maxVideoBW}`);
limitedBitrates[key] = that.maxVideoBW;
}
limitedBitrates[key] =

0 comments on commit 550bcc3

Please sign in to comment.