Fix no data in Presto (#8268)#71
Merged
betodealmeida merged 1 commit intolyft:lyft-masterfrom Sep 30, 2019
Merged
Conversation
* Fix no data in Presto * Fix test
Codecov Report
@@ Coverage Diff @@
## lyft-master #71 +/- ##
============================================
Coverage 64.75% 64.75%
============================================
Files 490 490
Lines 23855 23855
Branches 2630 2630
============================================
Hits 15448 15448
Misses 8254 8254
Partials 153 153
Continue to review full report at Codecov.
|
DiggidyDave
approved these changes
Sep 22, 2019
DiggidyDave
left a comment
DiggidyDave
left a comment
There was a problem hiding this comment.
As Beto and I discussed, I'm ok with this to unblock people as long as getting the actual fix in the P0 priority, so that we don't end up with an additional long-lived private change downstream of apache.
Author
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a bug in prod where if no data is returned in Presto an exception is raised. apache#8268 fixes it, but bringing it causes a major conflict due to apache#8258.
This PR cherry-picks apache#8268 to fix the problem, while we figure out how to handle the deck.gl migration to NPM.
👀 @DiggidyDave