Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Add S3GetAccessPointPolicy #3007

Merged
merged 5 commits into from
May 15, 2024
Merged

Conversation

tolujimoh
Copy link
Contributor

Description

This PR adds functionality for calling S3GetAccessPointPolicy to support clutch-private#2500

@tolujimoh tolujimoh requested a review from a team as a code owner May 14, 2024 17:10
@tolujimoh
Copy link
Contributor Author

/ptal #core-datastores-prs

Copy link
Contributor

@mikecutalo mikecutalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just did a first pass and left a few comments.

backend/service/aws/aws.go Outdated Show resolved Hide resolved
backend/service/aws/aws.go Outdated Show resolved Hide resolved
@tolujimoh tolujimoh requested a review from mikecutalo May 15, 2024 15:16
Copy link
Contributor

@mikecutalo mikecutalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@mikecutalo mikecutalo merged commit ca29fb4 into main May 15, 2024
10 checks passed
@mikecutalo mikecutalo deleted the add-support-s3-access-point branch May 15, 2024 17:29
@mikecutalo mikecutalo changed the title DS-10153: Add Functionality to aws client for calling S3GetAccessPointPolicy aws: Add S3GetAccessPointPolicy May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants