Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

housekeeping: Attempting to fix publishing and scaffolding #2995

Merged
merged 3 commits into from
May 1, 2024
Merged

housekeeping: Attempting to fix publishing and scaffolding #2995

merged 3 commits into from
May 1, 2024

Conversation

jdslaugh
Copy link
Contributor

Description

Previous fix didn't address issue.

  • Scaffolding is currently broken due to publish not having taken effect yet so it can't install the packages. Tested everything else locally and seems to be working correctly. Did add the .yarnrc.yml over to keep similar configuration settings as the base repo.
  • Publishing is done slightly different than Yarn v1 so adjusting as we go since it wasn't easy to test this beforehand.

Testing Performed

manual

@jdslaugh jdslaugh requested a review from a team as a code owner April 30, 2024 23:53
@jdslaugh jdslaugh merged commit 6fc1119 into main May 1, 2024
8 checks passed
@jdslaugh jdslaugh deleted the yarn4-patching2 branch May 1, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecr jecr jecr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdslaugh @jecr