frontend: leverage theme palette for misc components #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecr
force-pushed
the
theme-components-a
branch
from
399ff73
to
3aae15c
Compare
lucechal14
requested changes
Dec 12, 2023
jdslaugh
approved these changes
Dec 12, 2023
lucechal14
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following components to use the current theme colors, additionally, updates matching colors across the whole app to mantain consistency.
before/after screenshots
Accordion
Button
Button Group (Primary)
Button Group (Destructive)
Icon Button
Card
Normal
Hover
Chip
Confirmation
Tab
Note
This PR mainly aims to update ungrouped components within frontend/packages/core/src/, while updating all instances of widespread colors as to avoid possible mismatches from working them on a directory basis. Odd instances of hardcoded colors elsewhere will be addressed in future PRs.
Testing Performed
manual, unit testing