feat: add github markdown fragment quirk #1940
Conversation
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a new quirk to handle GitHub markdown blob URLs with fragments by converting them to raw GitHub URLs. This enables proper fragment checking by allowing lychee to parse the raw markdown content instead of the rendered HTML. The implementation updates the quirks system to pass regex captures to rewrite functions, enabling pattern-based URL transformations.
Key Changes:
- Updated quirk rewrite function signature to accept
Capturesparameter for pattern-based URL transformations - Added new
GITHUB_BLOB_MARKDOWN_FRAGMENT_PATTERNto match GitHub blob URLs with markdown fragments - Implemented URL rewrite logic to convert GitHub blob URLs to raw.githubusercontent.com URLs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Keming <kemingy94@gmail.com>
|
@mre @kemingy Why is copilot starting to comment on this PR? 😩 I really hate this. For example it lies/hallucinates about things and provides an unnecessary summary that is bigger than the diff.. Can we disable it globally for the whole organisation? I thought we already did 😅 |
I'm not sure why From what I know, this can be configured in the |
| pattern: &GITHUB_BLOB_MARKDOWN_FRAGMENT_PATTERN, | ||
| rewrite: |mut request, captures| { | ||
| let mut raw_url = String::new(); | ||
| captures.expand( |
2 participants
As discussed in #1729 (comment)