Fix typos, and configure the typos tool #1895
Conversation
|
Thank you for the PR. I agree that this is a nice addition. Also, I've just addressed the new linting issues on master. So by rebasing on master CI should pass again. |
These were found thanks to the typos[1] tool. [1] https://github.com/crate-ci/typos
This ignores the benches files, which are only used for benchmarking and shouldn’t be checked for typos.
|
Yay, the added CI job seems to work just fine! https://github.com/lycheeverse/lychee/actions/runs/18968249929/job/54169626137?pr=1895 I’ll remove the testing commit then. Edit: wow, that job finishes in just four seconds, that’s fast! Edit 2: #1897 fixes one small issue your clippy fix uncovered. |
They provide a GitHub Actions already: https://github.com/crate-ci/typos/blob/master/docs/github-action.md As we can see, this new job correctly fails when a typo is introduced: https://github.com/lycheeverse/lychee/actions/runs/18968249929/job/54169626137?pr=1895
|
Really cool, thanks for the PR. And yes four seconds is surprisingly quick. :) |
2 participants
typos is a nice tool which finds and fixes typos in a codebase.