Match more than one digit for version numbers#1889
Match more than one digit for version numbers#1889thomas-zahner merged 1 commit intolycheeverse:masterfrom
Conversation
83fe33e to
68cbed0
Compare
|
@thomas-zahner Ok, I think we need one more minor change based on this commit: 68cbed0, and these runs:
Basically, I'll refactor this PR to just make that change, and I think the Docker images will be properly tagged for the next release! |
68cbed0 to
5a86bde
Compare
|
@thomas-zahner Could you review? I believe this change is required (see: #1889 (comment)). |
thomas-zahner
left a comment
There was a problem hiding this comment.
Glad to hear that you could test the changes in your local repository and thank you for testing and submitting this PR.
5a86bde to
6c48cfc
Compare
Thanks for the review @thomas-zahner 🙇🏻 I thought you might ask for all three parts of the version number to be similarly handled. Here's a commit for testing: 6c48cfc Here's the test run with results:
I'll now refactor the PR to just have the required changes. |
6c48cfc to
d980255
Compare
|
Normally when I see (edit: It doesn't really matter that much, as the match is not used very often, but the group would match something like |
Thanks for chiming in @nobkd. I agree that |
|
They use the unescaped version of the dots in many patterns, so this probably works as intended 🤷 |
|
True, for correctness we could replace |
As suggested here: #1833 (comment) by @thomas-zahner, let's test the result of #1881.