fix: do not reuse excluded status from cache#1850
Merged
thomas-zahner merged 1 commit intolycheeverse:masterfrom Sep 12, 2025
Merged
fix: do not reuse excluded status from cache#1850thomas-zahner merged 1 commit intolycheeverse:masterfrom
thomas-zahner merged 1 commit intolycheeverse:masterfrom
Conversation
thomas-zahner
requested changes
Sep 12, 2025
Member
thomas-zahner
left a comment
thomas-zahner
left a comment
There was a problem hiding this comment.
Thanks for addressing this bug 🚀
Closed
This was referenced Oct 21, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that Uris in the cache whose status has in the meantime been excluded will not be reused.
If any more skips end up in
Cache::load, it would probably make sense to pass the entire config to it, rather than bits and pieces.Fixes: #1770