Conversation
Resolves #1657 by properly handling different types of Markdown reference links: - Reference links: [text][ref] - Collapsed links: [text][] - Shortcut links: [text] The issue was that reference link destinations were processed using extract_raw_uri_from_plaintext(), which relies on the linkify crate that only recognizes URLs with schemes (http://, https://, etc.) and ignores relative file paths like "target.md". Solution: 1. Enable footnote support (ENABLE_FOOTNOTES) to properly differentiate footnotes from reference links in pulldown-cmark 2. Add explicit handling to skip footnote events (FootnoteReference, FootnoteDefinition) since they're not links to check 3. Create RawUri directly for reference links to handle relative file paths that linkify doesn't recognize This approach is semantically correct - it leverages pulldown-cmark's built-in distinction between footnotes and reference links rather than using heuristics. Tests added to verify all reference link types are extracted correctly while footnotes are properly ignored.
- Remove unnecessary hashes from raw string literal - Add allow annotations for explicit footnote event handling - Add allow annotation for function length (102 lines vs 100 limit)
Closed
This was referenced Oct 21, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1657 by properly handling different types of Markdown reference links that were not being extracted by lychee:
[text][ref][text][][text]Root Cause
The issue was in the markdown extraction logic where reference link destinations were processed using
extract_raw_uri_from_plaintext(), which relies on the linkify crate. Linkify only recognizes URLs with schemes (http://, https://, etc.) and ignores relative file paths like "target.md".Solution
ENABLE_FOOTNOTES) to properly differentiate footnotes from reference links in pulldown-cmarkFootnoteReference,FootnoteDefinition) since they're not links to checkThis approach leverages pulldown-cmark's built-in semantic distinction between footnotes and reference links rather than using heuristics.
Test Plan
Verification
Before:
After:
The fix ensures lychee can now properly validate all types of Markdown reference links while maintaining backward compatibility.